{Geek} Spot the error

[robinbloke]

Spot the error, win a pint/drink thereof... and no, I didn't write this



int SimpleRound ( double high )
{

int low = (int) high;
double diff;
int result;

diff = high - low;
if (diff>=0)
result = ( diff >= (double)0.5000000 ) ? (low + 1) : low;
else
result = ( diff >= (double)-0.5000000 ) ? (low - 1) : low;
return (result);
}

Comments

[borusa.livejournal.com]

result = ( diff >= (double)-0.5000000 ) ? (low - 1) : low;

isn't right

Should be

result = ( diff < (double)-0.5000000 ) ? (low - 1) : low;

That right?

[robinbloke.livejournal.com]

Indeed so, for the first correct answer; you win a beverage of your choice :)

[borusa.livejournal.com]

It's a really dim way to do it as well.

int SimpleRound ( double high )
{
double temphigh;
temphigh += (double)0.5;
return (int)temphigh;
}

is so much more elegant.
And even that is poor, really, as it relies on the cast working as you expect. There's almost certainly a library function to do this anyway, and that should be used.

[borusa.livejournal.com]

correction

double temphigh=high;

Stupid non-edity comments

[robinbloke.livejournal.com]

Well the fun with this is; the above routine is reading in values from a text file from program B; The program I'm trying to fix (A) is writing these values; meaning I have to frig the values in order that it reads them correctly into the B, since I can't modify the code for it.
Huzah.

While I'm not a programmer...

[lanfykins.livejournal.com]

result = ( diff >= (double)0.5000000 ) ? (low + 1) : low;

a) is that a multiplication
b) should it be?

Re: While I'm not a programmer...

[robinbloke.livejournal.com]

Nope it's a macro C style if...then...else statement, which I hate.
RBS got the correct answer :)

[crocodilewings.livejournal.com]

Floating point error: Domain.

[robinbloke.livejournal.com]

I'm afraid that's not the answer on my card.

[crocodilewings.livejournal.com]

It's the answer on the DOS prompt!

[robinbloke.livejournal.com]

Well it's a code fragment, rather than a working program...

[crocodilewings.livejournal.com]

That's why I set it to main before compiling.

[robinbloke.livejournal.com]

Ahh well, you'd need to call it from main rather than set it to main; that would do the trick, probably.

[davefish.livejournal.com]

They have forgotten all the line numbers.

Runs of to hide

[robinbloke.livejournal.com]

Ahhh BBC Basic... I miss it so :(

[borange.livejournal.com]

mmm COMAL ...(iirc its what we were taught at school - sez the man given 36 hours to re-write his entire
O'grade project before final submission due to him having written it in BASIC and no teacher decided to tell me before then - damn them - still first successful oevr-nighter of code writing'ness how its stood me in good stead since then :O)

[davywavy.livejournal.com]

Oh, riiiiight

Hold competitions that I can't win booze from you in, I see :p

[robinbloke.livejournal.com]

Not my fault you can't code...